Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to get GraphQL 14 to work #15

Merged
merged 1 commit into from Jan 22, 2020
Merged

Conversation

flippidippi
Copy link
Contributor

Using the hack seen here join-monster/join-monster#352 (comment), this allows join-monster-graphql-tools-adapter to work with GraphQL 14 until graphql-js adds something like extensions described here graphql/graphql-js#1527.

This could, for the time being, fix #12

@flippidippi
Copy link
Contributor Author

@acarl005 Is this repo dead?

@lorensr
Copy link
Member

lorensr commented Jan 19, 2020

@flippidippi @GlennMatthys Now that extensions have been added to graphql@14.5.0, what's the non-hacky way to do this?

https://github.com/graphql/graphql-js/releases/tag/v14.5.0
graphql/graphql-js#2097

@flippidippi
Copy link
Contributor Author

I haven't done any research into how to get it working with the new graphql

@lorensr lorensr merged commit 9a376db into join-monster:master Jan 22, 2020
@lorensr
Copy link
Member

lorensr commented Jan 22, 2020

@flippidippi thanks for the response and PR—released in v0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typeConfig.sqlTable = jmConfig.sqlTable | graphql 14.0.0 problem
2 participants