Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tune README #170

Merged
merged 2 commits into from Jun 12, 2022
Merged

tune README #170

merged 2 commits into from Jun 12, 2022

Conversation

bikbah
Copy link
Contributor

@bikbah bikbah commented Feb 22, 2022

$ go get github.com/joho/godotenv/cmd/godotenv
go get: installing executables with 'go get' in module mode is deprecated.
        Use 'go install pkg@version' instead.
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.

Copy link

@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanak
Copy link

sanak commented May 30, 2022

@joho (CC: @luisdavim, @alexandear)
Could someone merge this ?

@alexandear
Copy link
Contributor

Sorry, but I can't merge because have no write access.

@sanak
Copy link

sanak commented May 30, 2022

@alexandear Okay, sorry for mentioning you. 🙇

@sanak
Copy link

sanak commented Jun 3, 2022

@joho @luisdavim
Could you merge this ?

If you care about older go versions, adding the following condition may be possible, but I am not sure whether library mode also needs to be fixed.


or if you want to use it as a bin command
go >= 1.17

go install github.com/joho/godotenv/cmd/godotenv@latest

go < 1.17

go get github.com/joho/godotenv/cmd/godotenv

@joho joho merged commit 26b87a7 into joho:main Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants