Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: convert windows \r\n to unix-style \n #159

Closed
wants to merge 1 commit into from

Conversation

coolaj86
Copy link
Contributor

@coolaj86 coolaj86 commented Sep 26, 2021

@joho
Copy link
Owner

joho commented Sep 27, 2021

I don't believe conversion is the appropriate solution.

  1. People who put specific linebreaks in an env var may very well have a good reason for it
  2. Ruby dotenv preserves them, and in general I try and preserve compatiblity/portability of env files between implementations

@coolaj86
Copy link
Contributor Author

Oh, I thought the test was failing on Windows because it preserved them. I must have misinterpreted the logs.

@coolaj86 coolaj86 closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants