Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added LoadFS from embed files #137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Enrico724
Copy link

@Enrico724 Enrico724 commented Mar 31, 2021

This adds the functionality of loading env files using embed.FS
Issue #138

@mickeyreiss
Copy link

@Enrico724 This is generally working for me, but it seems to be missing a method: OverloadFS.

added OverloadFS from embed files
@Enrico724
Copy link
Author

@mickeyreiss @joho I've just implemented OverloadFS.

@mickeyreiss
Copy link

@Enrico724 Awesome, thank you. I will pull this commit and post again if we encounter any issues.

@mickeyreiss
Copy link

This is working well for a large production application. Is there a path forward for merging this PR?

@Enrico724
Copy link
Author

Enrico724 commented Jun 24, 2021

This is working well for a large production application. Is there a path forward for merging this PR?

@mickeyreiss yes, there is

@hoshsadiq
Copy link

@Enrico724 you should use io/fs.FS instead of embed.FS. io/fs.FS can take other FS (e.g. afero) implementations too, whereas embed.FS can't.

@batara666
Copy link

Hi, umm, any update on this?

@Enrico724
Copy link
Author

Hi, umm, any update on this?
Still waiting the merge.

@batara666 @mickeyreiss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants