Write should always end with a newline #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnarlex
reviewed
Feb 1, 2021
gnarlex
approved these changes
Feb 1, 2021
|
I think this is still relevant. Just noticed that a script was broken. I have a go program that modifies .env files, and then another script tried to append to the modified .env file, assuming that every file is always ended with a newline. Since the go program didn't write the newline, the appended env var was added to the value of another key. |
|
I see this is already handled in #133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying an ini file I noticed the file did not end with a newline. Not sure if this was done intentionally, but this changes that.