Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use survey for prompt module #94

Merged
merged 2 commits into from Jun 12, 2023
Merged

feat: Use survey for prompt module #94

merged 2 commits into from Jun 12, 2023

Conversation

johnmanjiro13
Copy link
Owner

@johnmanjiro13 johnmanjiro13 commented Apr 30, 2023

Using survey instead of promptui because promptui has race condition problem.
We can pass tests with -race option by using survey.

promptui has race condition problem
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -10.52 ⚠️

Comparison is base (b42844e) 56.97% compared to head (8d1c8c4) 46.46%.

❗ Current head 8d1c8c4 differs from pull request most recent head 8c05027. Consider uploading reports for the commit 8c05027 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #94       +/-   ##
===========================================
- Coverage   56.97%   46.46%   -10.52%     
===========================================
  Files           4        4               
  Lines         337      325       -12     
===========================================
- Hits          192      151       -41     
- Misses        134      166       +32     
+ Partials       11        8        -3     
Impacted Files Coverage Δ
bumper.go 42.61% <0.00%> (-19.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnmanjiro13 johnmanjiro13 merged commit 2615f92 into main Jun 12, 2023
4 checks passed
@johnmanjiro13 johnmanjiro13 deleted the feature/survey branch June 12, 2023 15:18
@github-actions github-actions bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant