Update Electron to 22.0.3 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you didn't update the package.json? |
In package.json we have just the major version, it's a bump in the patch version, I used yarn upgrade-interactive. Thank you for merging! |
|
K, it's building now. I'll post the pre-release build link here when it's ready for you to test. I'm on my phone 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharp image manipulation is not working in Kit (check the image-resize example from the homepage).
I updated Electron from 22.0.0 to the latest stable (22.0.3) since sharp and other native modules are not working since Electron 21 because of the V8 memory cage feature. After the update I tested the image-resize and it's working again.
More info about the V8 memory cage: https://www.electronjs.org/blog/v8-memory-cage
The detection API added in Electron 22.0.1: https://github.com/electron/electron/releases/tag/v22.0.1 electron/electron#36624
The specific issue for sharp: lovell/sharp#3384
I hope you can merge this PR and and release this version soon.
Let me know if you have any change requests or suggestions and I will update the PR to help resolving this issue.