Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update extension to use event system of phpunit/phpunit:10.0.0 #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

localheinz
Copy link
Contributor

This pull request

  • updates the extension to use the new event system of phpunit/phpunit:10.0.0, 2023

Follows #83.
Related to sebastianbergmann/phpunit#4676.

πŸ’β€β™‚οΈ I will talk about Extending PHPUnit with its New Event System on October 25, 2022, at the International PHP Conference 2022 (Munich)

Since this extension is one of the few that I have been using and contributed to, I would like to use this pull request to demonstrate updating an existing extension to the new event system.

You recently updated the extension from the deprecated hooks interface to using the deprecated TestListener (see #83). phpunit/phpunit:10.0.0, which will be released on February 3, 2023, will remove the deprecated hooks and TestListener extension points.

To keep the diff small and understandable, I have tried to make the fewest changes possible.

I understand that there could be more work done, which I am happy to do, but I believe that this would be beyond the scope of this pull request.

@localheinz localheinz force-pushed the feature/phpunit-10 branch 7 times, most recently from ba1b4b1 to dc9f3e2 Compare October 24, 2022 15:45
@localheinz localheinz marked this pull request as ready for review February 3, 2023 12:08
@localheinz localheinz mentioned this pull request Feb 3, 2023
composer.json Outdated Show resolved Hide resolved
@localheinz localheinz force-pushed the feature/phpunit-10 branch 3 times, most recently from 00e07ed to ce30fec Compare February 7, 2023 15:09
@localheinz
Copy link
Contributor Author

For those of you coming here and looking for an alternative that works with phpunit/phpunit:10.0.0, try ergebnis/phpunit-slow-test-detector.

@dmitryuk
Copy link

Any chance to be merged?

@akondas
Copy link

akondas commented May 3, 2023

How can I help to make this merged?

@XWB
Copy link

XWB commented Jun 15, 2023

Ping @johnkary :)

Copy link

@akondas akondas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

"php": ">=7.2",
"phpunit/phpunit": "^8.0 || ^9.0"
"php": "^8.1",
"phpunit/phpunit": "^10.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how feasible is to keep currently still supported phpunit 9.x together with 10.x?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@localheinz can it be done, please, so this dep can be used for projects that still need PHP <8.1 support

@localheinz
Copy link
Contributor Author

Quick update: for those of you coming here and looking for an alternative that works with

  • phpunit/phpunit:^9.6.0
  • phpunit/phpunit:^10.4.0

I just released ergebnis/phpunit-slow-test-detector:2.4.0 with support for both.

@localheinz
Copy link
Contributor Author

Quick update: for those of you coming here and looking for an alternative that works with

  • phpunit/phpunit:^8.5.26
  • phpunit/phpunit:^9.6.0
  • phpunit/phpunit:^10.4.0

as well as

  • PHP 7.4
  • PHP 8.1
  • PHP 8.2
  • PHP 8.3

I just released ergebnis/phpunit-slow-test-detector:2.6.0 with support for all of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants