Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deprecation): move from deprecated listener to compatible hook system in PHPUnit 8 #67

Closed
wants to merge 1 commit into from
Closed

fix(deprecation): move from deprecated listener to compatible hook system in PHPUnit 8 #67

wants to merge 1 commit into from

Conversation

vlaurier
Copy link
Contributor

Closes #60

@vlaurier vlaurier force-pushed the handle-testlistener-deprecation branch from d472f1b to 0cd6b44 Compare January 20, 2020 13:29
vlaurier
vlaurier commented Jan 20, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
vlaurier
vlaurier commented Jan 20, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@vlaurier vlaurier mentioned this pull request Jan 21, 2020
Merged
@mremi
Copy link

mremi commented Feb 12, 2020

Hi @johnkary can you have a look please?

@johnkary johnkary added this to the 4.0 milestone Feb 12, 2020
@johnkary
Copy link
Owner

@vlaurier I have published a new v3.2.0 that updates the Travis CI matrix. Could you merge master into this branch, resolve conflicts and push again to this PR?

This new implementation will be the basis for SpeedTrap v4.0!

@vlaurier vlaurier force-pushed the handle-testlistener-deprecation branch from 0cd6b44 to 683699f Compare February 14, 2020 10:08
@vlaurier vlaurier force-pushed the handle-testlistener-deprecation branch from 683699f to 403e97b Compare February 14, 2020 10:15
@vlaurier
Copy link
Contributor Author

vlaurier commented Feb 14, 2020 •
edited

@johnkary @mremi
It should be good that way. Notice I also removed PHPUnit 7 support in composer.json as these changes are not BC.

@vlaurier
Copy link
Contributor Author

vlaurier commented Mar 5, 2020

@johnkary , are you OK with these changes then ?

@thePanz
Copy link

thePanz commented Mar 26, 2020

Any updates @johnkary ?

@angelsk
Copy link

angelsk commented May 11, 2020

Any ETA on this merge? Can I do anything to help test?

@VaN-dev
Copy link

VaN-dev commented Dec 7, 2020 •
edited

I would need this to be merged too. @vlaurier could you resolve the 2 conflict files please ?

@johnkary johnkary mentioned this pull request Dec 30, 2020
Closed
@johnkary
Copy link
Owner

Thank you, @vlaurier. I will have a look soon and merge toward a v4.0 release.

@localheinz
Copy link
Contributor

@johnkary

Also, if you can, please take a look at the ✉️ that I sent you in regard to the new event system of phpunit/phpunit!

🤓

@johnkary johnkary mentioned this pull request Mar 14, 2021
Merged
1 task
@johnkary johnkary removed this from the 4.0 milestone Mar 14, 2021
@johnkary
Copy link
Owner

@vlaurier Thank you again for your work implementing the Hooks system. I have built on top of your work and introduced PR #83 that completes the Hooks implementation. This will be a new major release version of SpeedTrap once merged.

Please follow progress of #83 for compatibility with PHPUnit 8.0+.

@johnkary johnkary closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch over to using hooks instead of implementing deprecated TestListener
9 participants
@vlaurier @mremi @johnkary @thePanz @angelsk @VaN-dev @localheinz @williamdes @vincentlaurier