Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry hook #36

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

real-yfprojects
Copy link
Collaborator

  • cleanup ordering in pyproject.toml
  • add pre-commit hooks for poetry check and poetry lock

@real-yfprojects
Copy link
Collaborator Author

Poetry lock slows down the pre-commit hooks considerably.

@johannesjh
Copy link
Owner

Note, the failed linting is probably due to klen/pylama#232

@real-yfprojects
Copy link
Collaborator Author

Note, the failed linting is probably due to klen/pylama#232

Can we lock the pydocstyle version in poetry?

* .pre-commit-config.yaml : Use the hooks provided in the poetry repository.

* poetry.lock : Update so that the new poetry-lock hook passes.
@johannesjh
Copy link
Owner

Yes, locking the version of pydocstyle to 6.1.x should be effective, judging from the root cause analysis in PyCQA/pydocstyle#621. I tried locking its version but for some reason this did not help, not sure why... maybe pre-commit did not use poetry to resolve the version of pydocstyle.

@real-yfprojects real-yfprojects merged commit e69e712 into johannesjh:main Jan 5, 2023
@real-yfprojects
Copy link
Collaborator Author

I tried locking its version but for some reason this did not help, not sure why... maybe pre-commit did not use poetry to resolve the version of pydocstyle.

Works for me when using poetry add 'pydocstyle<6.2'. How did you do it?

@real-yfprojects real-yfprojects deleted the poetry-hook branch January 5, 2023 18:09
@johannesjh johannesjh added this to the v0.2 milestone Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants