fix(CSU-Booking-Platform#425): fix remove last file submit crashes wh…

…en uploading Signed-off-by: Dan Seremet <dan_seremet@yahoo.com>
joeyabou · Mar 15, 2021 · 7401efb · 7401efb
1 parent 9315b20
commit 7401efb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/resources/js/Components/Form/SortableUpload.vue b/resources/js/Components/Form/SortableUpload.vue
@@ -131,6 +131,9 @@ import createFileList from "create-file-list";
                 files.splice(index, 1);
 
                 this.files = createFileList(files);
+                if (!this.files?.length) {
+                    this.files = [];
+                }
                 this.$emit("change", this.files);
             },
             drop(e) {

diff --git a/tests/Javascript/Components/Form/SortableUpload.spec.js b/tests/Javascript/Components/Form/SortableUpload.spec.js
@@ -27,6 +27,12 @@ beforeEach(() => {
                     size: 2267483,
                     type: "application/pdf",
                     webkitRelativePath: "",
+                },{
+                  lastModified: 1610336108413,
+                  name: "Sprint 6 Review.pdf",
+                  size: 2267483,
+                  type: "application/pdf",
+                  webkitRelativePath: "",
                 }],
             }
         }
@@ -83,6 +89,12 @@ test('should change when remove', () => {
     wrapper.vm.remove(1);
 
     expect(wrapper.emitted().change).toBeTruthy();
+
+    wrapper.vm.remove(1);
+    expect(wrapper.emitted().change).toBeTruthy();
+
+    wrapper.vm.remove(1);
+    expect(wrapper.emitted().change).toBeTruthy();
 })
 
 test('should change when drop', () => {