Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a memory leak appearing when some timeSeries.disabled === true #132

Merged
merged 2 commits into from Dec 7, 2021
Merged

fix: a memory leak appearing when some timeSeries.disabled === true #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d7bc2
fix: a memory leak appearing when some `timeSeries.disabled === true`
WofWca Sep 7, 2021
85cb245
docs: update changelog
WofWca Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions smoothie.js
View file
Open in desktop
Expand Up @@ -95,6 +95,7 @@
* Add title option, by @mesca
* Fix data drop stoppage by rejecting NaNs in append(), by @timdrysdale
* Allow setting interpolation per time series, by @WofWca (#123)
* Fix a memory leak appearing when some `timeSeries.disabled === true`, by @WofWca (#132)
*/

;(function(exports) {
Expand Down Expand Up @@ -910,18 +911,18 @@

// For each data set...
for (var d = 0; d < this.seriesSet.length; d++) {
context.save();
var timeSeries = this.seriesSet[d].timeSeries;

// Delete old data that's moved off the left of the chart.
timeSeries.dropOldData(oldestValidTime, chartOptions.maxDataSetLength);
if (timeSeries.disabled) {
continue;
}
context.save();

var dataSet = timeSeries.data,
seriesOptions = this.seriesSet[d].options;

// Delete old data that's moved off the left of the chart.
timeSeries.dropOldData(oldestValidTime, chartOptions.maxDataSetLength);

// Set style for this dataSet.
context.lineWidth = seriesOptions.lineWidth;
context.strokeStyle = seriesOptions.strokeStyle;
Expand Down