Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13 and update needed dependencies #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jones1008
Copy link

fixes #13

Also updates needed dependencies for this to work:

  • vite update needed for server.origin to work
  • vue update needed because otherwise:
    • @vue/compiler-sfc
      └── ✕ unmet peer vue@3.0.11: found 3.0.5

  • removed @vue/compiler-sfc because the latest vue version does not need it
  • @vitejs/plugin-vue update needed because otherwise:
    • @vitejs/plugin-vue
      └── ✕ missing peer @vue/compiler-sfc@^3.0.6

@leonardoinstaleap
Copy link

@jones1008 how you deploy to prod for example S3?

@jones1008
Copy link
Author

I have not thought about deploying... I actually ended up using Vue.js with webpack again since the support for Vite wasn't enough :/
Maybe it will be easier in the future when Vite is be shifting the prod bundles to ES Modules too(?). More info on that: https://laurentcazanove.com/articles/state-of-vue-2022-amsterdam-recap/#a-note-on-vite-3 and vitejs/vite#8178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets are loaded from single spa url instead of microfrontends
2 participants