Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] ENH: expose threading layer of mkl #48

Merged
merged 6 commits into from
Nov 6, 2019

Conversation

jeremiedbb
Copy link
Collaborator

side quest toward #47
it will allow to have a special behavior when using tbb as threading layer for mkl in our tests (e.g. with tbb, mkl_set_num_threads has no effect)

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a some basic test for the default case and an entry to the changelog.

@joblib joblib deleted a comment from codecov bot Oct 25, 2019
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add an entry to the changelog and feel free to merge.

@jeremiedbb
Copy link
Collaborator Author

I updated the change log. merging.

@jeremiedbb jeremiedbb merged commit f8ba6a6 into joblib:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants