Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP make default resource_tracker ignore FileNotFoundError? #340

Closed
wants to merge 1 commit into from

Conversation

ogrisel
Copy link
Collaborator

@ogrisel ogrisel commented Feb 4, 2022

I am wondering if we should just not make the resource tracker ignore FileNotFoundError by default for folders and files.

We have a test in joblib (test_resource_tracker_silent_when_reference_cycles) that is marked xfailed when the backend is joblib.

Not sure if this kind of situation should be dealt with specifically in joblib or more generally by default in loky. If we decide to do so, we to adapt the loky tests accordingly because the proposed change is breaking the assumption that and error should be raised.

Note that I have started to notice this kinds of warnings in the resource tracker also with the multiprocessing backend (with the PyPy CI worker), so maybe this should be changed in the upstream Python resource tracker config as well.

@ogrisel
Copy link
Collaborator Author

ogrisel commented Feb 7, 2022

Might not be necessary since it can be fixed in joblib directly: joblib/joblib#1263

Closing for now. But I am still open to changing my mind on this later.

@ogrisel ogrisel closed this Feb 7, 2022
@ogrisel ogrisel deleted the unlink-FileNotFoundError branch February 7, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant