Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid polluting memory namespace when caching functions in jupyter notebooks #1570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: avoid polluting memory namespace when caching functions in jupyter notebooks #1570

wants to merge 1 commit into from

Commits on Apr 9, 2024

  1. feat: avoid polluting memory namespace when caching functions in jupy… 

    …ter notebooks

while joblib previously correctly identified that part of the dynamically generated folder name for functions defined in a notebook depended on the pid and should be cut, it has missed that the filename was dynamically generated too and depended on the murmur2 hash of the function code.

this has lead to pollution of memory namespace on each function change. instead, we collapse the ipykernel namespace to a single static part and let joblib.Memory handle the invalidation on code changes as it's supposed to do.
    @banteg
    banteg committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    14a7905 View commit details
    Browse the repository at this point in the history