Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inspect.getsourcelines to get code #1550

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

androids-electric-sheep
Copy link
Contributor

@androids-electric-sheep androids-electric-sheep commented Feb 21, 2024

Fixing the bug outstanding in #1234. All credit to the original author as this is just rounding out that change

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6310841) 95.14% compared to head (98a6e4b) 95.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
- Coverage   95.14%   95.04%   -0.11%     
==========================================
  Files          44       44              
  Lines        7562     7548      -14     
==========================================
- Hits         7195     7174      -21     
- Misses        367      374       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcharras
Copy link
Contributor

Thanks for the PR @androids-electric-sheep , is it reasonable to say that there might still be differences in the code that is returned ? then shipping this into a new version might void the cache users built with a previous version. @tomMoral what is joblib policy on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants