Add option to specify an initialization function for 'loky' and 'multiprocessing' backends
#1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa8fc42.
shwina
commented
Nov 20, 2023
Comment on lines
+2035
to
+2036
| assert len(queue) == n_jobs | ||
| assert all(q == "spam" for q in queue) |
There was a problem hiding this comment.
@ogrisel I'm actually not sure what assertion I can make here (the current assertion seems not always to be true).
I want to test that every process that was started has run its init function.
However, it seems I sometimes reach line #2035 before all processes have been initialized - and by that time, the work has completed by fewer than the number of started processes.
Do you have any suggestions? Thanks!
There was a problem hiding this comment.
Hi @ogrisel -- just a gentle ping about this if you have any suggestions; thanks!
|
Hi @ogrisel - wondering if you have any thoughts on how to test the implementation here correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #381
This PR adds the ability to specify an initialization function that is run once per worker process when using the
'loky'and'multiprocessing'backends.Usage: