Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure precommit & ruff #1462

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

configure precommit & ruff #1462

wants to merge 9 commits into from

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Jun 23, 2023

as suggested in #1433 (comment) switch from flake8 to ruff also introduce recommit where I would suggest installing/enable pre-commit bot, which is free for open source and an advantage is that it performs fixing within PR so lex work for user/contributor and more consistent codebase...

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.15%. Comparing base (2be8dcd) to head (7784b77).

Files Patch % Lines
joblib/func_inspect.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1462      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.02%     
==========================================
  Files          45       45              
  Lines        7674     7674              
==========================================
- Hits         7303     7302       -1     
- Misses        371      372       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Borda
Copy link
Contributor Author

Borda commented Jul 6, 2023

@tomMoral could you pls have a look? 🐰

@jevandezande
Copy link

This looks great! Since Ruff 0.2.0, linting is moved to its own section (https://docs.astral.sh/ruff/configuration/):

[tool.ruff.lint]
    select = ["E", "W", "F"]

.pre-commit-config.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@Borda
Copy link
Contributor Author

Borda commented Mar 8, 2024

@jevandezande updated the lint. notation

@Borda
Copy link
Contributor Author

Borda commented Apr 12, 2024

@jevandezande could you please have another look 🦩

@jevandezande
Copy link

@Borda, sorry if there was any confusion, I'm not an official maintainer of this code, just an enthusiastic user and a supporter of using ruff for everything. The PR looks good to me, but you will need someone else to merge it.

@Borda
Copy link
Contributor Author

Borda commented May 7, 2024

@tomMoral @2ogrisel @lesteve, may I kindly ask you could have a look? 🦩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants