New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure precommit & ruff #1462
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1462 +/- ##
==========================================
- Coverage 95.16% 95.15% -0.02%
==========================================
Files 45 45
Lines 7674 7674
==========================================
- Hits 7303 7302 -1
- Misses 371 372 +1 ☔ View full report in Codecov by Sentry. |
@tomMoral could you pls have a look? 🐰 |
This looks great! Since Ruff 0.2.0, linting is moved to its own section (https://docs.astral.sh/ruff/configuration/):
|
@jevandezande updated the |
@jevandezande could you please have another look 🦩 |
@Borda, sorry if there was any confusion, I'm not an official maintainer of this code, just an enthusiastic user and a supporter of using ruff for everything. The PR looks good to me, but you will need someone else to merge it. |
as suggested in #1433 (comment) switch from
flake8
toruff
also introduce recommit where I would suggest installing/enable pre-commit bot, which is free for open source and an advantage is that it performs fixing within PR so lex work for user/contributor and more consistent codebase...