Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure native byte order for memmap. #1354

Merged
merged 3 commits into from Oct 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
Expand Up @@ -4,7 +4,8 @@ Latest changes
In development
--------------

- TODO
- Ensure native byte order for memmap arrays in `joblib.load`.
https://github.com/joblib/joblib/issues/1353

Release 1.2.0
-------------
Expand Down
2 changes: 1 addition & 1 deletion joblib/numpy_pickle.py
Expand Up @@ -229,7 +229,7 @@ def read_mmap(self, unpickler):
)
warnings.warn(message)

return marray
return _ensure_native_byte_order(marray)

def read(self, unpickler):
"""Read the array corresponding to this wrapper.
Expand Down