Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure arrays are bytes aligned in joblib pickles #1254

Merged
merged 31 commits into from Feb 25, 2022
Merged

Make sure arrays are bytes aligned in joblib pickles #1254

merged 31 commits into from Feb 25, 2022

Commits on Feb 2, 2022

  1. wip

    @lesteve
    lesteve committed Feb 2, 2022
    Copy the full SHA
    5b855cc View commit details
    Browse the repository at this point in the history

  2. fix

    @lesteve
    lesteve committed Feb 2, 2022
    Copy the full SHA
    232588b View commit details
    Browse the repository at this point in the history

  3. test

    @lesteve
    lesteve committed Feb 2, 2022
    Copy the full SHA
    282d953 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Remove debug print

    @lesteve
    lesteve committed Feb 3, 2022
    Copy the full SHA
    6b72bcf View commit details
    Browse the repository at this point in the history

  2. fix (peek not supported in io.BytesIO)

    @lesteve
    lesteve committed Feb 3, 2022
    Copy the full SHA
    ef5ddcd View commit details
    Browse the repository at this point in the history

  3. better variables

    @lesteve
    lesteve committed Feb 3, 2022
    Copy the full SHA
    a851f5c View commit details
    Browse the repository at this point in the history

  4. handle case where .tell not supported

    @lesteve
    lesteve committed Feb 3, 2022
    Copy the full SHA
    7cd90ed View commit details
    Browse the repository at this point in the history

  5. Fix memmap with old pickles loaded in mmap mode

    @lesteve
    lesteve committed Feb 3, 2022
    Copy the full SHA
    e0a994a View commit details
    Browse the repository at this point in the history

  6. Use module variable for array bytes alignment

    @lesteve
    lesteve committed Feb 3, 2022
    Copy the full SHA
    c8302dc View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Fix for Windows

    @lesteve
    lesteve committed Feb 4, 2022
    Copy the full SHA
    4952732 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/joblib/joblib into memmap… 

    …-align
    @lesteve
    lesteve committed Feb 4, 2022
    Copy the full SHA
    36cfa85 View commit details
    Browse the repository at this point in the history

  3. Fix test checking old non-aligned arrays with memmap

    @lesteve
    lesteve committed Feb 4, 2022
    Copy the full SHA
    513e0d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Add align_bytes_array attribute in NumpyArrayWrapper

    @lesteve
    lesteve committed Feb 8, 2022
    Copy the full SHA
    d7cbd3f View commit details
    Browse the repository at this point in the history

  2. lint

    @lesteve
    lesteve committed Feb 8, 2022
    Copy the full SHA
    d66f2bd View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Tweak

    @lesteve
    lesteve committed Feb 9, 2022
    Copy the full SHA
    7dab61b View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. trigger CI

    @lesteve
    lesteve committed Feb 10, 2022
    Copy the full SHA
    f943214 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Trigger CI

    @lesteve
    lesteve committed Feb 17, 2022
    Copy the full SHA
    fe5036d View commit details
    Browse the repository at this point in the history

  2. Create a numpy_array_alignment_bytes attribute to allow for future ch… 

    …ange of alignment
    @lesteve
    lesteve committed Feb 17, 2022
    Copy the full SHA
    0522f23 View commit details
    Browse the repository at this point in the history

  3. Add test for edge case where aligned numpy arrays are read in a file … 

    …handle that does not support tell
    @lesteve
    lesteve committed Feb 17, 2022
    Copy the full SHA
    41dc185 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge branch 'master' into memmap-align

    @ogrisel
    ogrisel committed Feb 23, 2022
    Copy the full SHA
    b2b2f92 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Tackled most comments

    @lesteve
    lesteve committed Feb 24, 2022
    Copy the full SHA
    73eb719 View commit details
    Browse the repository at this point in the history

  2. Add warning when loading an old pickle with non memory aligned array

    @lesteve
    lesteve committed Feb 24, 2022
    Copy the full SHA
    e6409e9 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry.

    @lesteve
    lesteve committed Feb 24, 2022
    Copy the full SHA
    a36af7c View commit details
    Browse the repository at this point in the history

  4. tweak

    @lesteve
    lesteve committed Feb 24, 2022
    Copy the full SHA
    54c2773 View commit details
    Browse the repository at this point in the history

  5. Forgotten f-string

    @lesteve
    lesteve committed Feb 24, 2022
    Copy the full SHA
    dfccb94 View commit details
    Browse the repository at this point in the history

  6. Windows fix

    @lesteve
    lesteve committed Feb 24, 2022
    Copy the full SHA
    236e042 View commit details
    Browse the repository at this point in the history

  7. Trigger CI

    @lesteve
    lesteve committed Feb 24, 2022
    Copy the full SHA
    3995ed4 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @lesteve @ogrisel
    lesteve and ogrisel committed Feb 25, 2022
    Copy the full SHA
    4705aad View commit details
    Browse the repository at this point in the history

  2. tweak

    @lesteve
    lesteve committed Feb 25, 2022
    Copy the full SHA
    2e380bb View commit details
    Browse the repository at this point in the history

  3. Update joblib/test/test_numpy_pickle.py

    @ogrisel
    ogrisel committed Feb 25, 2022
    Copy the full SHA
    eb69803 View commit details
    Browse the repository at this point in the history

  4. Trigger CI

    @lesteve
    lesteve committed Feb 25, 2022
    Copy the full SHA
    188c089 View commit details
    Browse the repository at this point in the history