New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for missing _multiprocessing module #1246
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 88.43% 87.29% -1.15%
==========================================
Files 47 48 +1
Lines 7082 7090 +8
==========================================
- Hits 6263 6189 -74
- Misses 819 901 +82
Continue to review full report at Codecov.
|
I'm a bit confused why |
To give more context, CPython can be built without multiprocessing, in which case This MR generally is part of the effort to update the version of joblib used in Pyodide. So far we have been using 0.11 because it's the last version before the loky addition, which has a bit more multiprocessing imports. |
I think joblib/loky#309 fixes these tests. |
Thank you for the PR pointing out the issue. We cannot merge a PR with failing tests. We probably need to wait for joblib/loky#309 |
With a closer look, I wonder if it is not better to try to put all the guards in joblib and not loky: loky makes no sense without multiprocessing. I'm giving it a quick try right. |
I am making an attempt to complete this in #1256 |
Closing in favor of #1256. |
Thanks for the contribution @hoodmane ! |
Pyodide and other single-threaded Python builds will be missing the _multiprocessing module. Test that joblib still works in this environment.
Test is currently failing
This is a blocker for Pyodide to upgrade joblib.