Add default value for StoreBackendBase.compress #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 94.52% 94.54% +0.01%
==========================================
Files 47 47
Lines 6960 6961 +1
==========================================
+ Hits 6579 6581 +2
+ Misses 381 380 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127.
Ideally we would need update the tests but the bare try / except in
StoreBackendBase.dump_itemmakes this difficult and looks like an anti-pattern anyway. However I am not sure which exception we should expect in case of a race condition in the creation of directory (probablyOSError?). We probably need more tests, including multi-threaded stress tests to check for the robustness of concurrent directory creation.@aabadie if you are still interested in this, please feel free to send a PR :)