-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent spurious cache clearing when calling a cached func inside a Parallel call #1093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
- Coverage 94.52% 93.91% -0.62%
==========================================
Files 47 47
Lines 6910 6955 +45
==========================================
Hits 6532 6532
- Misses 378 423 +45
Continue to review full report at Codecov.
|
@ogrisel feel free to take a look, this is reviewable :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# an environement where the introspection utilitiees get_func_code | ||
# relies on do not work (typicially, in joblib child processes). | ||
# See #1035 for more info | ||
# TODO (pierreglaser): do the same with get_func_name? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. It does not seem to be required to fix #1035 though (I tried manually with the reproducer in an interactive ipython session).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tried to stop and restart the ipython session and the cache survived.
Thank you very much @pierreglaser . Actually, I forgot to update the changelog prior to merging this. I will do it now. |
Fixes #1035
cc @ogrisel - I need to test a few more cases, but it should be reviewable.