Small test improvement #1068
Open
Small test improvement #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 47 47
Lines 6849 6851 +2
=======================================
+ Hits 6469 6471 +2
Misses 380 380
Continue to review full report at Codecov.
|
|
What does this do? Should it be merged |
|
I think so. As in python3, we rely on the |
tomMoral
approved these changes
Oct 7, 2021
| @@ -536,10 +536,13 @@ def test_nested_exception_dispatch(backend): | |||
| We rely on the Python 3 built-in __cause__ system that already | |||
| report this kind of information to the user. | |||
| """ | |||
| with raises(ValueError) as excinfo: | |||
| with raises((ValueError, MyExceptionWithFinickyInit)) as excinfo: | |||
There was a problem hiding this comment.
This will never be called as we don't pass custom_exception to the exception_raiser so probaly better to not complicate the test?
Suggested change
| with raises((ValueError, MyExceptionWithFinickyInit)) as excinfo: | |
| with raises(ValueError) as excinfo: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to reproduce the
test_nested_exception_dispatch[loky]failure observed in #1055 as it seems unrelated to dask.