Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store backend mixin assuming 'compress' attrib #1127

Open
majidaldo opened this issue Nov 11, 2020 · 1 comment · May be fixed by #1139
Open

store backend mixin assuming 'compress' attrib #1127

majidaldo opened this issue Nov 11, 2020 · 1 comment · May be fixed by #1139

Comments

@majidaldo
Copy link

majidaldo commented Nov 11, 2020 •
edited

https://github.com/joblib/joblib/blob/c98b6944cfa4d65409e9092afa54a6bd505b9350/joblib/_store_backends.py#189

...which is not always true. Would need to add 'compress' to the abstract sig

joblib/joblib/_store_backends.py

Line 122 in c98b694

def configure(self, location, verbose=0, backend_options=dict()):

@ogrisel ogrisel linked a pull request Dec 15, 2020 that will close this issue
Open
@ogrisel
Copy link
Contributor

ogrisel commented Dec 15, 2020 •
edited

Thanks for the report. I opened a PR with minimal fix in #1139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default value for StoreBackendBase.compress ogrisel/joblib
2 participants
@ogrisel @majidaldo