Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Replace mime-types with mini_mime for content type lookup #769

Merged
merged 1 commit into from
Dec 30, 2022

Commits on Nov 10, 2022

  1. Replace mime-types with mini_mime for content type lookup

    `mini_mime` is a minimal mime type library that's more performant and
    less memory hungry.
    https://github.com/discourse/mini_mime
    
    It has replaced `mime-types` in the `mail` gem: (which is a dependency
    of `actionmailer`, and by extension, `rails`)
    mikel/mail#1059
    
    As well as `capybara`:
    teamcapybara/capybara#1884
    
    Which also means using it as a dependency of `httparty` would be able to
    reuse the same dependency that should be already available in most Rails
    apps, instead of pulling in an extra `mime-types` dependency.
    
    The change in code is pretty straightforward, the same one made by the
    capybara PR linked above.
    carlosantoniodasilva committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    366745b View commit details
    Browse the repository at this point in the history