Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edge case cookie format with a blank attribute #685

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

jeisen
Copy link
Contributor

@jeisen jeisen commented Feb 6, 2020

Akamai, whether due to a bug or intentional change, started to send HTTP responses with Set-Cookie headers that appear to violate the Cookie RFC by including a blank parameter. Traditional browsers appear to handle the change without issue, but HTTParty throws an exception when copying this cookie from the response to a subsequent request.

Sample invalid header:

Set-Cookie: somekey=someval; domain=mydomain.com; path=/; ; Secure

This change silently drops the invalid parameter and treats the remainder of the header as valid.

@jnunemaker
Copy link
Owner

Part of me doesn't want to include fixes for incorrect things, but this feels pretty minor so I'm 🆒 with it. Thanks for contributing!

@jnunemaker jnunemaker merged commit 375e82c into jnunemaker:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants