Skip to content

Commit

Permalink
Add BigDecimal to gem dependency
Browse files Browse the repository at this point in the history
## Summary

BigDecimal gem has been bundled gem since Ruby 3.3.0-dev.

- https://bugs.ruby-lang.org/issues/19843
- ruby/ruby@1c93288

So, this PR adds BigDecimal to runtime gem dependency.

## Other Information

The ruby-head of gems that depends on crack has warned:

```console
$ ruby -v
ruby 3.3.0dev (2023-08-22T14:46:32Z master 7127f39bac) [x86_64-darwin22]

$ cd path/to/rubocop/rubocop
$ bundle update
$ bundle exec rake spec
/Users/koic/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/crack-0.4.5/lib/crack/xml.rb:9: warning:
bigdecimal will be not part of the default gems since Ruby 3.4.0. Add it to your Gemfile.
```
  • Loading branch information
koic committed Aug 23, 2023
1 parent a951228 commit d2988a9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions crack.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ Gem::Specification.new do |gem|
gem.version = Crack::VERSION
gem.license = "MIT"

gem.add_runtime_dependency("bigdecimal")
gem.add_runtime_dependency("rexml")
end

0 comments on commit d2988a9

Please sign in to comment.