Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some components to functional components #195

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Igsu-Bravo
Copy link

πŸš€ Description

Converted the following components to functional components:

Additionally upgraded a few dependencies

πŸ“„ Motivation and Context

#128

πŸ§ͺ How Has This Been Tested?

Basic interactions with the UI and comparing behavior to the current master branch. I'd suggest to build an E2E test suit at this point as the UI is still relatively simple πŸ‘€

πŸ“· Screenshots (if appropriate)

πŸ“¦ Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

βœ… Checklist

  • My code follows the code style of this project(Do your best to follow code styles. If none apply just skip this).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Igsu-Bravo
Copy link
Author

There are quite a bit of styling differences. I can setup a prettier configuration and push to this feature branch if you want, otherwise I can remove the styling differences from my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant