Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pgx versioned names #868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

maraino
Copy link

@maraino maraino commented May 31, 2023

This commit adds support for the driver names pgx/v4 and pgx/v5. These aliases of different versions of pgx allows loading the proper driver if a dependency of a project imports a different one.

This commit adds support for the driver names pgx/v4 and pgx/v5. These
aliases of different versions of pgx allows loading the proper driver if
a dependency of a project imports a different one.

Signed-off-by: Mariano Cano <mariano.cano@gmail.com>
@BenKnigge
Copy link

BenKnigge commented Aug 5, 2023

I've merged this into my fork at https://github.com/BenKnigge/sqly If you would be interested in helping maintain it. The help would be appreciated.

Edit : let's all start using and contributing to the fork at https://github.com/go-sqlx/sqlx

@maraino
Copy link
Author

maraino commented Aug 7, 2023

Hey @BenKnigge, do you know https://github.com/go-sqlx/sqlx? It's another fork from @uvulpos that has also been active recently? If you don't, you two should sync up and see if there's a common path forward. I would gladly contribute where I can.

@BenKnigge
Copy link

yes, I've been helping him out with that. We've got the tests running in git hub over the weekend. I would love to get several of these outstanding pr's merged into that fork ASAP. I'll likely drop my fork in favor of contributing to his. Could you make this a pr for that fork?

@dlsniper dlsniper added the could merge The PR look safe enough to merge label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could merge The PR look safe enough to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants