Named query for Conn #780
Open
Named query for Conn #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @ardan-bkennedy, and I recently stepped in to help maintain this project. |
dlsniper
added
the
requires attention
|
Hello.
Yes, I still need it.
From: Florin Pățan ***@***.***>
Sent: Thursday, February 1, 2024 4:47 PM
To: jmoiron/sqlx ***@***.***>
Cc: Козлов Евгений ***@***.***>; Author ***@***.***>
Subject: Re: [jmoiron/sqlx] Named query for Conn (PR #780)
Hello, @ardan-bkennedy<https://github.com/ardan-bkennedy>, and I recently stepped in to help maintain this project.
We are sorting the opened issues and pull requests and would like to know if you still NEED this merged.
Thank you for your contribution.
—
Reply to this email directly, view it on GitHub<#780 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOXJJTN5JTY5E2V2M6YCGH3YROMDPAVCNFSM5GJKL3WKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJSGEZTMMZQHEZA>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
Thank you for the quick reply. Can you please help us understand the reason for the change? I couldn't find an open issue for this particular feature. This would help us better triage and prioritize the PRs and their scopes. Thank you. |
|
In my project I can`t use connection pool, only dedicated connection. And I already use named parameters for queries.
It is the reason to make this PR. Right now I use my fork in project. If PR will be merged – I`ll switch to original sqlx package.
From: Florin Pățan ***@***.***>
Sent: Friday, February 2, 2024 10:13 AM
To: jmoiron/sqlx ***@***.***>
Cc: Козлов Евгений ***@***.***>; Author ***@***.***>
Subject: Re: [jmoiron/sqlx] Named query for Conn (PR #780)
Thank you for the quick reply. Can you please help us understand the reason for the change?
I couldn't find an open issue for this particular feature.
This would help us better triage and prioritize the PRs and their scopes.
Thank you.
—
Reply to this email directly, view it on GitHub<#780 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOXJJTIUIASG4APX4RLVFPDYRSGYVAVCNFSM5GJKL3WKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJSGMYTKMRZHA2A>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named query for Conn.