Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/go-sql-driver/mysql #589

Closed
wants to merge 1 commit into from
Closed

Bump github.com/go-sql-driver/mysql #589

wants to merge 1 commit into from

Conversation

mpolden
Copy link

@mpolden mpolden commented Jan 14, 2020

While trying to understand why my project pulled in
google.golang.org/appengine/cloudsql indirectly, I noticed that it's pulled in
through this library's dependency on github.com/go-sql-driver/mysql.

$ go mod why -m google.golang.org/appengine
# google.golang.org/appengine
github.com/mpolden/zdns/sql
github.com/jmoiron/sqlx
github.com/jmoiron/sqlx.test
github.com/go-sql-driver/mysql
google.golang.org/appengine/cloudsql

However, I then noticed that a newer version of the dependency removes
google.golang.org/appengine/cloudsql as it's obsolete: go-sql-driver/mysql#1007.

@coveralls
Copy link

coveralls commented Jan 14, 2020

Pull Request Test Coverage Report for Build 133

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.751%

Totals Coverage Status
Change from base Build 122: 0.0%
Covered Lines: 1000
Relevant Lines: 1476

💛 - Coveralls

@mpolden mpolden requested a review from jmoiron January 15, 2020 11:07
@jmoiron
Copy link
Owner

jmoiron commented Jun 13, 2020

Thanks, sorry I missed this, done via another PR. 🙇

@jmoiron jmoiron closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants