Fix panic on invalid number #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent work. I would be open to including some fuzzing infrastructure in this repo if you feel like raising a PR. For the more "intrusive" change, feel free to open a PR and we can work through it. Definitely keen to prevent panics & stack overflows. |
|
I'll open a separate PR when time allows for the others. Where can I view the results of a travisci run? I can seem to find that and it will be useful when doing the fuzzing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a small check for a case that would previous panic. This was found through fuzzing. I've found another issue where it is possible to overflow the stack using a query with a long series of ['s. The change for this might be intrusive though. Before I fix it I wanted to send this PR up and check to see if you are interested in the more intrusive change.