treat tuples as lists #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #180 +/- ##
========================================
Coverage 98.19% 98.19%
========================================
Files 14 14
Lines 1441 1441
========================================
Hits 1415 1415
Misses 26 26
Continue to review full report at Codecov.
|
|
Looks good to me, we just need to get tests added and then I'll merge this. I'm happy to write these if no one has time. |
jamesls
reviewed
May 12, 2020
| @@ -202,7 +202,7 @@ def visit_identity(self, node, value): | |||
| def visit_index(self, node, value): | |||
| # Even though we can index strings, we don't | |||
| # want to support that. | |||
| if not isinstance(value, list): | |||
| if not isinstance(value, (list, tuple)): | |||
There was a problem hiding this comment.
Given this is duplicated below I'd suggest moving this up to line 110 and add a LIST_TYPE that we can reuse.
|
Hi. Are there any plans to have this merged soon ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe now any tuples in input data should be treated as lists.
use case described in the issue #179 now works as expected in the issue