New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0.0 #43
7.0.0 #43
Conversation
Happy new year! π
Library source updated for Rollup v1.0.0 API (Closes #42)
It seems as though the file watcher is being excesively reinitialized, whereby only certain files end up being watched. The Chokidar watcher may yet be the best solution, but for now it will be removed while the core preprocessor is refactored.
Each entrypoint has its own bundle, so the previous implementation seemed to be ineffectual. Oops! :)
Partial reimplementation of #39
Begin reimplementation of the custom file watcher.
So it turns out the basePath and log were not necessary, because Karma already outputs when files change... got love removing code! What's more, this implementation appears to fix #28 and fix #41 due to its use of Karma's internal `FileList.changeFile` method (exposed on the Server "EventEmitter"). This still needs more thorough testing, but I'm optimistic.
Sorry, can't test it, because we use |
@jlmakes I can confirm this works for my build. Thanks for all the hard work! |
@jlmakes Got the following error with ERROR [preprocessor.rollup]: Failed to process ./test\index.jsTypeError [ERR_INVALID_ARG_VALUE]: The argument 'path' must be a string or Uint8Array without null bytes. Received '\u0000commonjsHelpers'
at Object.stat (fs.js:818:3)
at FSWatcher.NodeFsHandler._addToNodeFs (~\node_modules\chokidar\lib\nodefs-handler.js:454:20)
at FSWatcher.<anonymous> (~\node_modules\chokidar\index.js:648:12)
at ~\node_modules\async-each\index.js:16:7
at Array.forEach (<anonymous>)
at each (~\node_modules\async-each\index.js:15:11)
at FSWatcher.add (~\node_modules\chokidar\index.js:647:5)
at Watcher.add (~\node_modules\karma-rollup-preprocessor\lib\Watcher.js:16:16)
at preprocess (~\node_modules\karma-rollup-preprocessor\lib\index.js:24:15) |
@fengyuanchen: Oooh, I forgot about null bytes! (re: #30) @abaksha-sc: That seems like a reasonable request, although one thing that comes to mind is that the Out of curiosity, why isn't your team upgrading to |
@jlmakes works for my build! |
Yes, we decided to try to upgrade |
@jlmakes Thanks for the update. I've tried this in my project and it's working great π |
@jlmakes Works fine in my project now with |
It works for my build. @jlmakes Thank you for your project. |
Works in my build, thanks:)
|
Thanks for your work, can confirm that
|
Works nice, thanks! |
Thanks for the feedback everyone! |
The next major release of
karma-rollup-preprocessor
in response to Rollup 1.0 πPre-release
Added
1.0.0
#42Changed
< 1.0.0
< 8.0.0
run_start
event. #41Fixed
Hey all! ππ½
@isidrok @tatey @niksy @thisconnect @calebdwilliams @abaksha-sc @Paulskit @LvChengbin
@ckbo3hrk @pantosha @MartijnR @fengyuanchen @givanse @wifilinker @danielnaab
You all have participated in issues addressed in this release β if you don't mind, please help test by installing the pre-release (under the
next
tag):