Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE on windows with missing jna/jansi (fixes #930) #933

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

gnodet
Copy link
Member

@gnodet gnodet commented Jan 19, 2024

No description provided.

@gnodet gnodet added this to the 3.25.1 milestone Jan 19, 2024
Copy link
Contributor

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch while I am confused why this was never noticed...

@gnodet
Copy link
Member Author

gnodet commented Jan 19, 2024

Good catch while I am confused why this was never noticed...

This has been refactored in 2.23.0 and only happens when the JLine is badly configured. A simple upgrade should work out of the box if JNA or Jansi is present. This may have surfaced because the JNI provider is missing the native libraries, and that one should be used by default.

@gnodet gnodet merged commit 7ad41da into jline:master Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants