Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict Argument checking broken with relative completion offset #202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix strict Argument checking broken with relative completion offset #202

wants to merge 2 commits into from

Conversation

tkruse
Copy link
Contributor

@tkruse tkruse commented Aug 11, 2015

I found a small regression in ArgumentCompleter when one of the involved completers returns a partial completion (meaning one with an offset. I believe this was introduced here:

2de5902

-            if (subCandidates.size() == 0) {
+            if (!subCandidates.contains(arg)) {

@tkruse
Copy link
Contributor Author

tkruse commented Aug 11, 2015

I found another problem if the candidate has a delimiter appended. Fixed that, but the code looks bloated. Not sure if anyone can find a more elegant solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant