fix: shouldn't merge (program) call frame #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is something I'm running into frequently myself. Tried out the changes in the PR locally and they address the issue. With this PR the Chrome profiles look correct again. |
marvinhagemeister
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this great work!
I am able to use speedscope to analyze
.cpuprofile, but sometimes it behaves differently from devtools:CPU-20200515T093903.cpuprofilein speedscope:And in devtools the flamegraph is like:
Maybe we shouldn't to merge the
(program)frame to keep the same behavior with chrome devtools.