Fix the build for node 13.x, make travis test 10, 12, 13, stable #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,5 @@ | |||
| language: node_js | |||
| node_js: | |||
| - '9' | |||
| - '10' | |||
| - '12' | |||
There was a problem hiding this comment.
Maybe worth explicitly adding 13 as well?
There was a problem hiding this comment.
node or latest may be better than 13 (fail early).
jlfwong
force-pushed
the
jlfwong/bump-transitive-deps
branch
from
d181274
to
c867b48
Compare
|
This should be good to go, but Travis is down for scheduled maintenance, so I'm going to wait for it to come back up to make sure this gets through CI. |
jlfwong
changed the title
jackerghan
pushed a commit
to jackerghan/speedscope
that referenced
this pull request
Jul 28, 2023
…wong#263) @JustinBeckwith pointed out in jlfwong#262 that `npm install` was broken in node 13.x, and @DanielRuf pointed in jlfwong#254 that test fail for node 11+ because of a change to stability of sorting. This PR seeks to address both of those. The installation issue was fixed by just regenerating `package-lock.json` without needing to bump any of the direct dependency versions. The test failure issue requires manual intervention. To fix the sort stability issue, I updated the tests to use the stable sort values (these were all the correct values, though some of the test values were incorrect). To make the suite still pass for node 10, I added a hack where I override `Array.prototype.sort` with a stable implementation that's *only* used in tests (See comments in code for a justification for why) ## Test Plan Before this PR: `npm install` on node 13.x fails & `npm run jest` results in test failures After this PR: `npm install` on node 13.x passes & `npm run jest` passes for node 10, 12, and 13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JustinBeckwith pointed out in #262 that
npm installwas broken in node 13.x, and @DanielRuf pointed in #254 that test fail for node 11+ because of a change to stability of sorting.This PR seeks to address both of those.
The installation issue was fixed by just regenerating
package-lock.jsonwithout needing to bump any of the direct dependency versions. The test failure issue requires manual intervention.To fix the sort stability issue, I updated the tests to use the stable sort values (these were all the correct values, though some of the test values were incorrect).
To make the suite still pass for node 10, I added a hack where I override
Array.prototype.sortwith a stable implementation that's only used in tests (See comments in code for a justification for why)Test Plan
Before this PR:
npm installon node 13.x fails &npm run jestresults in test failuresAfter this PR:
npm installon node 13.x passes &npm run jestpasses for node 10, 12, and 13.