Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoder namespace bug #1

Closed
wants to merge 3 commits into from
Closed

Encoder namespace bug #1

wants to merge 3 commits into from

Commits on Feb 4, 2018

  1. Use t.Run for some encoder tests 

    Wrap each encoder test case with t.Run for improved test output and
ability to selectively run specific sub tests.
    @jkanywhere
    jkanywhere committed Feb 4, 2018
    Copy the full SHA
    cb3eb92 View commit details
    Browse the repository at this point in the history

  2. Demonstrate jsonEncoder and MapObjectEncoder differences 

    Add test cases to demonstrate uber-go#554,
how jsonEncoder and MapObjectEncoder handle namespaces differently.

Specifically: When foo.MarshalLogObject uses OpenNamespace,
jsonEncoder.AddObject does not close the namespace.
    @jkanywhere
    jkanywhere committed Feb 4, 2018
    1
    Copy the full SHA
    367a5f7 View commit details
    Browse the repository at this point in the history

  3. Fix type in comment

    @jkanywhere
    jkanywhere committed Feb 4, 2018
    Copy the full SHA
    9cc8d3d View commit details
    Browse the repository at this point in the history