Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ENH Implement sparse support #4

Closed
wants to merge 5 commits into from
Closed

[WIP] ENH Implement sparse support #4

wants to merge 5 commits into from

Conversation

mbatoul
Copy link
Collaborator

@mbatoul mbatoul commented Aug 3, 2021 •
edited

What does this implement/fix? Explain your changes.

Add sparse support for pairwise distances.

Any other comments?

This is still a WIP.

Todo

  • Discuss current design
  • Parametrize test_csr_csr_pdist_consistency and test_csr_dense_pdist_consistency tests with metrics
  • Split DistanceMetric#pairwise testing function into pairwise_dense and pairwise_sparse?
  • Implement Euclidean sparse-sparse in EuclideanDistance#csr_cdist
  • Benchmark sparse-dense vs. dense-sparse to decide which one is the more efficient
  • Implement the more efficient approach in EuclideanDistance#csr_dense_cdist

@mbatoul mbatoul changed the title Implement sparse dist Sparse support Aug 3, 2021
@mbatoul mbatoul changed the title Sparse support ENH Implement sparse support Aug 3, 2021
@mbatoul mbatoul changed the title ENH Implement sparse support [WIP] ENH Implement sparse support Aug 3, 2021
@mbatoul mbatoul added enhancement New feature or request No Changelog Needed labels Aug 3, 2021
@jjerphan jjerphan mentioned this pull request Aug 4, 2021
Closed
11 tasks
@jjerphan
Copy link
Owner

Hi @mbatoul, do you still have time to work on this PR or can this PR be superseded?

@jjerphan
Copy link
Owner

Closing as it's being superseded by scikit-learn#23585.

@jjerphan jjerphan closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request No Changelog Needed
Projects
None yet
Milestone
No milestone
2 participants
@mbatoul @jjerphan