Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix github workflows. #565

Merged
merged 3 commits into from May 21, 2023
Merged

fix: Fix github workflows. #565

merged 3 commits into from May 21, 2023

Conversation

damencho
Copy link
Member

@damencho damencho commented May 17, 2023

ubuntu-18.04 was deprecated and is no longer available.

ubuntu-20.04 includes various PHP versions from ppa:ondrej/php (see https://github.com/actions/runner-images/blob/main/images/linux/scripts/installers/php.sh). That ppa also includes custom packaged version of libpcre*, which break standard Ubuntu packages, namely openjdk-11-jdk. Get rid of them via ppa-purge.

The runner images for ubuntu-22.04 fortunately no longer has that stuff, see actions/runner-images#6331.

@ibauersachs
Copy link
Member

Use a Docker image locally to Debug this or you'll get insane.

Also, don't copy the ports sources if you're not building for x86/x86-64.

@ibauersachs
Copy link
Member

ibauersachs commented May 17, 2023

Oh, and check if the proposed pocket is still active. That has had broken dependencies for a while even in 22.04.

@damencho
Copy link
Member Author

Well it behaves differently in the Docker and in the github workflows ... different problems, different dependencies missing ...

@damencho
Copy link
Member Author

One of the problem I see on the docker is that it tries to install at the same time cpp and cpp:i386 and the second one removes the first one ...

@damencho
Copy link
Member Author

And seems there is more to that ... while debugging it I see "Broken libtool:arm64" ...

@damencho
Copy link
Member Author

And apparently I need --platform linux/amd64 when running on m1. I changed only ARG ARCH=x86 in the Dockerfile (and adding ENV DEBIAN_FRONTEND=noninteractive because of tzdata) and everything went fine, success.

So the problems seems specific to the github images used for the workflows.

@ibauersachs
Copy link
Member

I'll try to have a look tonight.

@damencho
Copy link
Member Author

So the pulse lib is a conflict with git about libpcre2-8-0:amd64 or libpcre2-8-0:i386 .. maybe if we move to git:i386 ... :) I may try it out to see will that change anything.

@damencho
Copy link
Member Author

damencho commented May 18, 2023

Well the same conflict comes from libselinux1 ... not sure how to solve it then ...

@damencho
Copy link
Member Author

Can we actually drop i386 builds at all ?

@damencho
Copy link
Member Author

But actually arm64 and ppc64el fail with the same.

@damencho
Copy link
Member Author

I don't see another option for now other than dropping the static building which means jitsi-desktop and jigasi will not run on x86, arm64 and ppc64el anyway we build jigasi only for amd64 ... maybe not a big deal for the moment. And fixing the windows and bullseye failures ... WDYT @ibauersachs

@ibauersachs
Copy link
Member

Not giving up quite yet, and this is definitely an issue with the GitHub actions runners. The other option is to build with Docker on the Actions.

@damencho
Copy link
Member Author

O yeah, you are right I forgot I ran it and install everything fine on the Docker image once I fixed the m1 shenanigan ...
🤞

@ibauersachs ibauersachs merged commit 150396b into master May 21, 2023
0 of 3 checks passed
@ibauersachs ibauersachs deleted the up-linux-runner branch May 21, 2023 12:13
@damencho
Copy link
Member Author

🕺 Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants