Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X3-88886: to avoid empty namespace value like xmlns:ds="" #236

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

X3-88886: to avoid empty namespace value like xmlns:ds="" #236

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
862d15a
X3-88886: Signed Facturae XML not validated
FranckDepoortere May 23, 2018
0e495b9
"repository": {"type": "git","url": "git://github.com/Sage-ERP-X3/xml…
FranckDepoortere May 23, 2018
ff25ef4
Update package.json
FranckDepoortere May 23, 2018
fc890c0
avoid empty namespace url
eboureau May 23, 2018
83451af
avoid empty namespace url
eboureau May 23, 2018
65138cd
avoid empty namespace url
eboureau May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions dom.js
View file
Open in desktop
Expand Up @@ -1011,9 +1011,13 @@ function serializeToString(node,buf,isHTML,nodeFilter,visibleNamespaces){
if (needNamespaceDefine(node,isHTML, visibleNamespaces)) {
var prefix = node.prefix||'';
var uri = node.namespaceURI;
var ns = prefix ? ' xmlns:' + prefix : " xmlns";
buf.push(ns, '="' , uri , '"');
visibleNamespaces.push({ prefix: prefix, namespace:uri });
if (uri) {
// Avoid empty namespace value like xmlns:ds=""
// Empty namespace URL will we produce an invalid XML document
var ns = prefix ? ' xmlns:' + prefix : " xmlns";
buf.push(ns, '="' , uri , '"');
visibleNamespaces.push({ prefix: prefix, namespace:uri });
}
}

if(child || isHTML && !/^(?:meta|link|img|br|hr|input)$/i.test(nodeName)){
Expand Down