upgrade jpeg-js dependency #979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Node8 checks seem to fail because gifs will occasionally take more than 2000ms. I've rerun CircleCI multiple times and have differing test results on the same branch commit.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
jpeg-js has fixed a new issue. Pixel 4 XL phones took malformed .jpegs, which raised exceptions in previous versions of jpeg-js.
What else might be affected
Yarn.lock seemed out of date, thus the various changes to yarn.lock. There also seemed to be an old version of jpeg-js that got automatically removed, however tests all passed. No other packages have dependencies to older versions of jpeg-js so removing previous versions should be fine.
Tasks
jimp.d.tsUnnecessary