This repository has been archived by the owner on Jun 20, 2021. It is now read-only.
Remove old client #288
Open
Remove old client #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jigar288
commented
Apr 26, 2021
•
jigar288
commented
- removing old html client since it isn't necessary
- removing some fixme comments
- ignore the first two commits (they're showing up even though they're in master and I pulled from master)
anarmawala
approved these changes
Apr 26, 2021
| this.#app.use(cors({ credentials: true })) //! FIXME: update cors configuration after deployment | ||
| this.#app.use(cors({ credentials: true })) |
There was a problem hiding this comment.
Maybe we should add the origin restriction here as well?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.