Add testcase and fix for attributes deduplication in form and empty elements #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhy
reviewed
May 6, 2023
jhy
requested changes
May 6, 2023
|
(BTW, I am happy to make that change myself if you prefer, LMK.) |
|
Thank you for responding to my PR. I took a quick look at the code path and I'm not familiar enough with the code to try any major refactoring but I can certainly factor out the deduplication code. |
Also add new testcase and fix for attributes deduplication in empty tags
To use spaces instead of tabs as rest of the file
perlan
changed the title
|
When looking at the code path, I realized that deduplication was not applied for empty tags either so I added another test case and fix for empty tags as well. |
jhy
approved these changes
May 8, 2023
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to handle deduplication of attributes in form-elements and should fix #1949