Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/safelist deep copy constructor #1763

Merged
merged 3 commits into from May 15, 2022
Merged

Fix/safelist deep copy constructor #1763

merged 3 commits into from May 15, 2022

Commits on May 6, 2022

  1. Add test case for shared state of Safelist's copy constructor

    @cschwier
    cschwier committed May 6, 2022
    Copy the full SHA
    4e68bcc View commit details
    Browse the repository at this point in the history

  2. Fix copy constructor of Safelist 

    Copies nested data structures instead of using a shallow copy to avoid
unexpected state mutations after copy constructor usage.
    @cschwier
    cschwier committed May 6, 2022
    Copy the full SHA
    aebe4a2 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary mutability of Safelist interna 

    Makes a couple of properties final which shouldn't be replaced to further
reduce the risk of unexpected mutation.
    @cschwier
    cschwier committed May 6, 2022
    Copy the full SHA
    8f1820b View commit details
    Browse the repository at this point in the history