grpcreflect supports v1 of the reflection service #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
force-pushed
the
jh/reflection-v1
branch
from
8c060c4
to
71c2a11
Compare
jhump
force-pushed
the
jh/reflection-v1
branch
from
71c2a11
to
1dfaa5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grpcreflectclient has, up to this point, only worked with the original "v1alpha" version of server reflection.This updates it to also work with v1. This requires a tweak to the API, since it previously included "v1alpha" in the method signature, requiring the caller to provide a v1alpha RPC stub.
Now the caller can provide a connection interface (not a particular stub), and the client can try both, attempting to use v1 first and then falling back to v1alpha if that returns an "unimplemented" error.