no need for srcinforeflection package #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage; but sourceinfo.GlobalFiles needs to implement add'l methods to serve extension info
jhump
force-pushed
the
jh/no-need-for-srcinforeflection
branch
from
17314e8
to
3112d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I may be able to get a PR merged (grpc/grpc-go#5197) that makes the
srcinforeflectionpackage here unnecessary. Since this was never included in a release, I do not consider it a compatibility issue to remove it.That PR will require the
sourceinfopackage's resolver also implement methods related to resolving extensions, so that enhancement is also included in this PR.So I'm queuing this up, but will only merge if/when that other gRPC PR is merged.